🤖 fix: deterministic project ordering when no custom order set #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sortProjectsByOrder() returned projects in Map insertion order when projectOrder was empty. This caused flaky snapshots in the Comprehensive demo story because insertion order varies with mock setup. Now sorts lexically when no custom order is set, ensuring consistent render order regardless of data construction. --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Comprehensive demo story had flaky snapshots because projects in the sidebar did not render in a consistent order when
projectOrderwas empty (initial state in Storybook).Root cause:
sortProjectsByOrder()returned projects in Map insertion order whenorderwas empty. Map insertion order depends on how data is constructed, making it non-deterministic across test runs.Solution
When no custom order is set, sort projects lexically instead of using insertion order. This guarantees a stable, deterministic render order.
Impact
projectOrderis non-empty, so existing sort logic appliesGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high